> On 2009-10-17 02:39:13, Matt Rogers wrote: > > the d-pointer is nice, but we don't prefix d-pointer member variables with > > 'm' or 'm_'. If you have an svn account, please commit. If you don't have > > one, let me know and I'll commit it, with the aforementioned d-pointer > > changes.
I have encountered a problem with my solution (happend with a metacontact included MSN/ICQ), but don't know how to reproduce it (how to add a contact twice to a chatsession): in kopetechatsession.cpp there is a signal "contactadded" emitted, even if a contact is not added, because he already is contained in the session (in method "addContact"). Is this signal-emitting essential or may I remove it? Because the memberslistmodel will add the contact twice in the other case. Another solution would be to check, if the contact is already in the memberslistmodel, but that would make it more intelligent as it should be? I don't understand why the "addContact" method in chatsession is so complicated. What cases have to have such special treatment? - Cyberbeat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1862/#review2677 ----------------------------------------------------------- On 2009-10-16 17:11:52, Cyberbeat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1862/ > ----------------------------------------------------------- > > (Updated 2009-10-16 17:11:52) > > > Review request for Kopete. > > > Summary > ------- > > - Changed the chatmemberlistmodel so that it sorts the contacts by > onlinestatus-weight/nickname (important for IRC). > - chatmemberlistmodel manages it's own sorted list of contacts > - implemented the "FIXME"s so that the add/remove slots do not call "reset()" > anymore, which takes a lot of time for big irc channels > - added signal/slot for nickname-change to chatsession (model needs to know > for resorting) > > > Diffs > ----- > > branches/KDE/4.3/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.h > 1035610 > > branches/KDE/4.3/kdenetwork/kopete/libkopete/chatsessionmemberslistmodel.cpp > 1035610 > branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetechatsession.h 1035610 > branches/KDE/4.3/kdenetwork/kopete/libkopete/kopetechatsession.cpp 1035610 > > Diff: http://reviewboard.kde.org/r/1862/diff > > > Testing > ------- > > works for me with IRC, ICQ,.. > > > Screenshots > ----------- > > IRC with sorted members > http://reviewboard.kde.org/r/1862/s/228/ > > > Thanks, > > Cyberbeat > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
