----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1815/#review4450 -----------------------------------------------------------
/trunk/KDE/kdenetwork/kopete/protocols/skype/skypeaccount.cpp <http://reviewboard.kde.org/r/1815/#comment3927> Here is problem. If skype sent message, when Kopete is offline (or Kopete was restarted before message is sent), session is NULL (because d->sessions doesnt contains chat ID) So if session is NULL, Kopete crashed - Pali On 2009-12-31 19:27:24, Benson Tsai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1815/ > ----------------------------------------------------------- > > (Updated 2009-12-31 19:27:24) > > > Review request for Kopete. > > > Summary > ------- > > Currently, the skype plugin does not show a message until it receives > acknowledgement via dbus that the message is sent. This introduces a human > noticeable between when the user presses enter and when the message shows up. > The delay is even longer for the first message because skype has to setup the > session. To improve the situation, I modified the skype plugin to use message > status to indicate sending/sent and append the message instantly instead of > waiting for the ack. > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.h 1067407 > /trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.cpp 1067407 > /trunk/KDE/kdenetwork/kopete/protocols/skype/skypeaccount.h 1067407 > /trunk/KDE/kdenetwork/kopete/protocols/skype/skypeaccount.cpp 1067407 > /trunk/KDE/kdenetwork/kopete/protocols/skype/skypechatsession.h 1067407 > /trunk/KDE/kdenetwork/kopete/protocols/skype/skypechatsession.cpp 1067407 > > Diff: http://reviewboard.kde.org/r/1815/diff > > > Testing > ------- > > Chatted with friends with the patch applied. It appears to work. > > > Thanks, > > Benson > > _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
