> On 2010-08-30 19:47:51, Raphael Kubo da Costa wrote: > > Well, since nobody else has said anything on this patch, I think it may be > > safe to commit it. Do you have an account?
No, I don't. So can anyone else commit it? - Igor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/5175/#review7300 ----------------------------------------------------------- On 2010-08-28 12:11:14, Igor Poboiko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/5175/ > ----------------------------------------------------------- > > (Updated 2010-08-28 12:11:14) > > > Review request for Kopete. > > > Summary > ------- > > Currently, notifications for incoming messages has default and unusable title > 'Kopete Messenger', and body like 'Incoming message from %user%: "squashed > messag...". This patch sets title for all incoming message notifications to > 'Incoming message from %user%' and body to squashed message (which can be > longer now). It is a bit more usable. > > > This addresses bug 248101. > https://bugs.kde.org/show_bug.cgi?id=248101 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/libkopete/private/kopeteactivenotification.h > 1167882 > /trunk/KDE/kdenetwork/kopete/libkopete/private/kopeteactivenotification.cpp > 1167882 > /trunk/KDE/kdenetwork/kopete/libkopete/private/kopeteviewmanager.cpp > 1167882 > > Diff: http://reviewboard.kde.org/r/5175/diff > > > Testing > ------- > > Works fine with single message and with messages which are shown with '+N > more messages'. > There is a problem if we don't have Notifications widget. In this case > notifications are shown as grey balloons, and it ignores message title. I > think it is KNotify bug and it should be fixed. > > > Thanks, > > Igor > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
