----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6333/#review9678 -----------------------------------------------------------
Ship it! Do you have commit access or do you need someone to commit this for you? - Raphael On Jan. 15, 2011, 11:58 a.m., Cristi P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6333/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2011, 11:58 a.m.) > > > Review request for Kopete. > > > Summary > ------- > > a) seems like yahoo protocol doesn't send back in the webcam invitation > accepted which person did that. and there is a variable to remember who we > sent the last invite to. Problem would be if several invites are going to be > sent. So, I made the invitation name to be an invitation *list*. Inspired by > code in libpurple. > > b) there is a typo when code tries to guess who the 'accepted invitation' is > coming from. I don't have a good way to replicate, but mostly I suspect it > happens when you're sending several invitations (see point a) ) or when some > online<->offline switches are happening. > Concrete side effect is that code tries to connect to server "". > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/webcamtask.h 1214563 > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/webcamtask.cpp > 1214563 > > Diff: http://svn.reviewboard.kde.org/r/6333/diff > > > Testing > ------- > > Just that the code still works ok (sending/receiving webcam images) since I > don't have yet a clear way to reproduce the problems. > > > Thanks, > > Cristi > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
