-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6526/
-----------------------------------------------------------
Review request for Kopete.
Summary
-------
This patch fixes another problem with kopete's "Last Seen" feature.
If a contact was online when you close kopete no "last seen" time is shown for
the contact (once kopete is started again and the given contact is offline
then).
The reason was quite obvious:
-first the contact list was saved to the XML file.
-then all accounts were told to disconnect
-that updated the last seen property of all contacts
-the contact list was NOT written to the HDD again
I could not find a reason why the two lines should not be moved.
All objects which are required by the AccountManager and the ContactList are
still in memory.
But I'd like someone with better Qt event loop knowledge (due to the
deleteLater() calls) to review this, as I'm not 100% sure if I haven't
overlooked anything.
This addresses bug 266697.
https://bugs.kde.org/show_bug.cgi?id=266697
Diffs
-----
/trunk/KDE/kdenetwork/kopete/libkopete/kopetepluginmanager.cpp 1221653
Diff: http://svn.reviewboard.kde.org/r/6526/diff
Testing
-------
The "last seen" property now even survives restarts of kopete :)
Thanks,
Martin
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
