----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6544/ -----------------------------------------------------------
(Updated Feb. 25, 2011, 4:01 p.m.) Review request for Kopete. Summary (updated) ------- In jabbercontact.cpp line 87: * Note: The only time account->myself() could be a * NULL pointer is if this contact here is the myself() * instance itself. Since in that case we wouldn't * get updates at all, we need to treat that as a * special case. So to check if this contact is a regular contact you would use if ( account->myself() ) but currently this is done the other way around. Do I understand this right? Or are the comments just in wrong order (see r2)? Diffs ----- /branches/KDE/4.6/kdenetwork/kopete/protocols/jabber/jabbercontact.cpp 1222695 Diff: http://svn.reviewboard.kde.org/r/6544/diff Testing ------- Thanks, alter_schwede
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
