----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6581/#review9948 -----------------------------------------------------------
This patch break compilation on Windows. #ifdef Q_OS_UNIX can be used for *nix specified code. - Pali On March 4, 2011, 8:10 p.m., Martin Blumenstingl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6581/ > ----------------------------------------------------------- > > (Updated March 4, 2011, 8:10 p.m.) > > > Review request for Kopete. > > > Summary > ------- > > This patch fixes another problem with kopete's "Last Seen" feature. > > If a contact was online when you CTRL-C kopete (or shutdown your computer) no > "last seen" time is shown for > the contact (once kopete is started again and the given contact is offline > then). > > The reason was quite obvious: > kopete did not do a clean shutdown when getting SIGTERM/SIGINT > > I implemented a simple signal handler which takes care of the SIGTERM/SIGINT > signals. > > NOTE: This patch depends on this one: http://svn.reviewboard.kde.org/r/6526/ > > > This addresses bug 267654. > https://bugs.kde.org/show_bug.cgi?id=267654 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/main.cpp 1223740 > > Diff: http://svn.reviewboard.kde.org/r/6581/diff > > > Testing > ------- > > I CTRL-C'ed kopete and asked a buddy to go offline. > His "Last seen" property was correctly shown once I started kopete again. > > NOTE: This patch depends on this one: http://svn.reviewboard.kde.org/r/6526/ > > > Thanks, > > Martin > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
