> On March 20, 2011, 6:26 p.m., Lamarque Souza wrote: > > trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp, line 1005 > > <http://svn.reviewboard.kde.org/r/6620/diff/1/?file=45655#file45655line1005> > > > > I have just commit a slighly different version of this patch. Thanks > > for pointing this problem out. > > > > Please close this review request.
Thanks. That was SVN revision 1225401. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6620/#review9995 ----------------------------------------------------------- On March 18, 2011, 3:04 p.m., Alexander Potashev wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6620/ > ----------------------------------------------------------- > > (Updated March 18, 2011, 3:04 p.m.) > > > Review request for Kopete. > > > Summary > ------- > > Properly use KNotification::event (the first argument, eventId, should be > listed in kopete.notifyrc). Also reduced code duplication. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1225209 > > Diff: http://svn.reviewboard.kde.org/r/6620/diff > > > Testing > ------- > > It builds for me, but I didn't run any tests. > > > Thanks, > > Alexander > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
