> On May 29, 2011, 1:47 p.m., Carlos Federico Aguirre wrote: > > /trunk/KDE/kdenetwork/kopete/kopete/infoeventwidget.cpp, lines 231-232 > > <http://svn.reviewboard.kde.org/r/6586/diff/5/?file=46051#file46051line231> > > > > why don't you make this feature optional ? may be enabled by default :) > > > > i suggest refactor this condition in a method, so it'll be easy to add > > more scenarios where kopete will not send notifications > > Pali Rohár wrote: > Ok, special method for checking if notification should be show is good > idea. (Here can be condition for configured away status too). And for away > status we have checkbox in kopete settings. > > But this is for Busy/Do not Disturb status. I think that busy status is > special status without notifications - so why to have this feature optional? > - I think that this should be part of busy starus. Why then we have more > kopete statuses?
ok, i agree, I thought the feature was "Disable notifications" not "Disable notifications in Busy status". is not clear to me what are you going to do, will you post a updated diff ? or .... - Carlos Federico ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6586/#review10161 ----------------------------------------------------------- On April 13, 2011, 7:18 p.m., Pali Rohár wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6586/ > ----------------------------------------------------------- > > (Updated April 13, 2011, 7:18 p.m.) > > > Review request for Kopete. > > > Summary > ------- > > This patch disable all visible KNotification for account which is in Busy > status. > > > This addresses bugs 143586, 184113, 205303, and 229306. > https://bugs.kde.org/show_bug.cgi?id=143586 > https://bugs.kde.org/show_bug.cgi?id=184113 > https://bugs.kde.org/show_bug.cgi?id=205303 > https://bugs.kde.org/show_bug.cgi?id=229306 > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/kopete/infoeventwidget.cpp 1227880 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetechatsession.cpp 1227880 > /trunk/KDE/kdenetwork/kopete/libkopete/kopetemetacontact.cpp 1227880 > /trunk/KDE/kdenetwork/kopete/libkopete/kopeteutils.cpp 1227880 > /trunk/KDE/kdenetwork/kopete/libkopete/private/kopeteviewmanager.cpp > 1227880 > /trunk/KDE/kdenetwork/kopete/plugins/otr/authenticationwizard.cpp 1227880 > /trunk/KDE/kdenetwork/kopete/plugins/privacy/privacyplugin.cpp 1227880 > /trunk/KDE/kdenetwork/kopete/protocols/gadu/gaduaccount.cpp 1227880 > /trunk/KDE/kdenetwork/kopete/protocols/groupwise/gwaccount.cpp 1227880 > /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabberaccount.cpp 1227880 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqaccount.cpp 1227880 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/icq/icqcontact.cpp 1227880 > /trunk/KDE/kdenetwork/kopete/protocols/oscar/oscaraccount.cpp 1227880 > /trunk/KDE/kdenetwork/kopete/protocols/skype/libskype/skype.cpp 1227880 > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmaccount.cpp 1227880 > /trunk/KDE/kdenetwork/kopete/protocols/yahoo/yahooaccount.cpp 1227880 > > Diff: http://svn.reviewboard.kde.org/r/6586/diff > > > Testing > ------- > > Tested, no notifications are visible when Busy status is selected globaly. So > now it is real Do not Disturb / Busy status in Kopete (without notifications). > > > Thanks, > > Pali > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
