-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111227/
-----------------------------------------------------------
(Updated June 24, 2013, 10:49 p.m.)
Review request for Kopete.
Description (updated)
-------
This patch ports kopete-otr to libotr 4.0.0
Changes:
-> support for translating libotr-generated messagess.
-> incoming unencrypted messages during an ecrypted session can now be threated
as normal messages producing a notification and saved to history (Bug 204502)
-> Along with the port I worked around the crash with incoming messages during
key generation (Bugs 195328, 218570, 298681, 304105, 306276, 309987, 318255)
-> Multiple chat session to the same user with different resources can now be
distinguished
Because the original code was rather badly formatted the change also contains
some formatting changes which I'm not sure what exactly is the difference. I
tried to make as few coding style changes as possible.
Oh, and it does add some new strings, but shouldn't change any existing ones.
The ones newly added are the ones that have been inside libotr before -
hardcoded to english. So even if we would ship this patch without updating
translations, translation wise it would look the same as before. So, do you
guys think we could squeeze it into 4.11 still?
This addresses bugs 195328, 204502, 218570, 298681, 304105, 306276, 309987, and
318255.
http://bugs.kde.org/show_bug.cgi?id=195328
http://bugs.kde.org/show_bug.cgi?id=204502
http://bugs.kde.org/show_bug.cgi?id=218570
http://bugs.kde.org/show_bug.cgi?id=298681
http://bugs.kde.org/show_bug.cgi?id=304105
http://bugs.kde.org/show_bug.cgi?id=306276
http://bugs.kde.org/show_bug.cgi?id=309987
http://bugs.kde.org/show_bug.cgi?id=318255
Diffs
-----
CMakeLists.txt 18896be
cmake/modules/FindLibOTR.cmake e9dbf31
plugins/otr/authenticationwizard.h a4dea40
plugins/otr/authenticationwizard.cpp e4d5d13
plugins/otr/kopete_otr.desktop 2429868
plugins/otr/otrguiclient.h 0347075
plugins/otr/otrguiclient.cpp 11329db
plugins/otr/otrlchatinterface.h 5bb6e1d
plugins/otr/otrlchatinterface.cpp 56ffd0c
plugins/otr/otrlconfinterface.h 0cfdf29
plugins/otr/otrlconfinterface.cpp 7d58462
plugins/otr/otrplugin.h 35ecb7b
plugins/otr/otrplugin.cpp ef973ed
plugins/otr/otrpreferences.h 7aa742c
plugins/otr/otrpreferences.cpp ece403a
plugins/otr/privkeypopup.h 4b271e9
plugins/otr/privkeypopup.cpp 3fea9e2
Diff: http://git.reviewboard.kde.org/r/111227/diff/
Testing
-------
Tested with XMPP against Pidgin (OTRv3) and Adium (OTRv2). The overall handling
of messages (escaping, parsing etc) did not change with this patch, so it
shouldn't break any other protocol. Still, some more testing wouldn't hurt if
you have some other protocols in use you can test with.
Thanks,
Michael Zanetti
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
