> On July 4, 2013, 9:28 a.m., Pali Rohár wrote: > > protocols/jabber/jabberclient.h, line 358 > > <http://git.reviewboard.kde.org/r/111361/diff/1/?file=167074#file167074line358> > > > > use TAB here > > Roman Nazarenko wrote: > If I understand you correctly, you require me to use tabular key for > indentation? This is kinda prohibited by the KDELibs coding style guidelines, > which, I assume, Kopete should inherit. Let me know if I'm wrong and I shall > take a look at the Qt Creator's indentationing options, though, tabs are > prohibited not without a reason. > > Pali Rohár wrote: > Problem is that in kopete are used more coding styles. And I want to see > at least one coding style in specified file. In file jabberclient.h are used > TABs instead spaces and mixing both looks horrible. There are more problems > in your patch, not only in jabberclient.h. > > But for future it could be nice to have all kopete files formatted in > same coding style (kdelibs or something other)... Is there any tool which can > reformat source files?
yes, there are several tools, for example astyle: http://astyle.sourceforge.net/ and as qtcreator plugin: http://histomatics.de/proasp.php - Volker ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111361/#review35559 ----------------------------------------------------------- On July 2, 2013, 12:34 p.m., Roman Nazarenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111361/ > ----------------------------------------------------------- > > (Updated July 2, 2013, 12:34 p.m.) > > > Review request for Kopete. > > > Description > ------- > > Standard draft: http://xmpp.org/extensions/xep-0136.html > Github repo: https://github.com/Jtalk/kopete-fork-xep0136/tree/XEP-0136 > > This is an Iris task for message archiving support. > I also added appropriate tab to the XMPP account editing widget. > > I have implemented preferences setting, chats collections retrieval and chat > logs retrieval. Comments inside the code will give you some extra information > about this alpha's restructions and problems. We also need History plugin to > be patched to make this thing work. > > > Diffs > ----- > > protocols/jabber/ui/jabbereditaccountwidget.cpp 75cc7c1 > protocols/jabber/ui/jabbereditaccountwidget.h 07f7e70 > protocols/jabber/ui/dlgjabbereditaccountwidget.ui 0f819ae > protocols/jabber/tasks/jt_archive.cpp PRE-CREATION > protocols/jabber/tasks/jt_archive.h PRE-CREATION > protocols/jabber/jabberclient.cpp bc3f37b > protocols/jabber/jabberclient.h 6d791c0 > protocols/jabber/CMakeLists.txt f0c64d3 > > Diff: http://git.reviewboard.kde.org/r/111361/diff/ > > > Testing > ------- > > Click-click, it works. > I also checked collections retrieval, but that code is vanished from the > final version. Worked well though. > > > Thanks, > > Roman Nazarenko > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
