Am Mittwoch, 24. Juli 2013, 20:25:51 schrieb Pali Rohár:
> Hello,
>
> On Wednesday 24 July 2013 19:57:07 Burkhard Lück wrote:
> > Hi kopete-devels,
> >
> > some issues with the module kopete/plugins/cryptography/:
> >
> > 1) i18n
> > Messages from plugins/cryptography/ are extracted twice to the
> > two translation catalogs kopete.po and
> > kopete-cryptography.po.
> > All other messages from the plugins subdirs are extracted to
> > the catalog kopete.po, so it seems to logical to do that for
> > the plugin cryptography as well, right?
>
> Right. All kopete libraries, protocols and plugins using
> kopete.po. If you can fix message extraction for cryptography
> plugin, please do it.
>
Done and merged cryptography translation for all languages into their main
kopete catalogs.
> > 2) documentation
> > kopete/plugins/cryptography has a separate docbook while any
> > other plugins are included in the kopete docbook.
> > So from a doc pov it makes sense to insert the cryptography
> > docbook into the main kopete docbook as well.
> > Any objections?
>
> Yes, it make sense to have documentation in one docbook where are
> also other plugins too.
>
Will do that and try to get kopete "green" on
http://techbase.kde.org/Projects/Documentation/KDE4_(health_table)
> > 3) build
> > The plugin cryptography is only build if kleopatra (headers +
> > library) are installed, but apparently the cmake module
> > FindKleopatra.cmake (searching for the include dir
> > kleo/kleo_export.h - not installed by kleopatra - and the
> > library kleo - no kleopatra library named like that) is
> > broken. So with the broken FindKleopatra.cmake the module
> > cryptography is never build and installed.
> > Obviously FindKleopatra.cmake or the kleopatra installation
> > needs to be fixed to be able to use of the cryptography
> > module.
>
> What do you suggesting to do? Before merging plugin back to
> master I did not know about this problem (because I used ubuntu
> and it has kleo dev package with include files - so it working fine
> on ubuntu) and nobody was against merging it. Note that
> cryptography plugin doing transparent GPG message
> encryption/decryption and signing/verification which is really
> usefull for security. Before merging I fixed this plugin and
> (after successfull compilation) it working fine.
You are right, with kdepim-dev package from ubuntu/debian the cryptograpy
plugin builds fine, but only because they patched kdepim to export all
necessary stuff, see attachment.
But it should be possible to build cryptograpy plugin with kdepim build from
sources.
Reading the commit log of kopete/plugins/CMakeLists.txt this has been a
problem since several years.
The only way to fix this issue seems to be to talk with the kdepim devels and
use a similar approach as in the attached ubuntu/debian patch.
--
Burkhard Lück
Index: b/kleopatra/libkleopatraclient/CMakeLists.txt
===================================================================
--- a/kleopatra/libkleopatraclient/CMakeLists.txt
+++ b/kleopatra/libkleopatraclient/CMakeLists.txt
@@ -6,3 +6,8 @@ add_subdirectory(gui)
add_subdirectory(tests)
+install(
+ FILES kleopatraclient_export.h
+ DESTINATION ${INCLUDE_INSTALL_DIR}/libkleopatraclient
+ )
+
Index: b/kleopatra/libkleopatraclient/core/CMakeLists.txt
===================================================================
--- a/kleopatra/libkleopatraclient/core/CMakeLists.txt
+++ b/kleopatra/libkleopatraclient/core/CMakeLists.txt
@@ -72,3 +72,12 @@ else(WINCE)
endif()
install(TARGETS kleopatraclientcore ${INSTALL_TARGETS_DEFAULT_ARGS})
+
+install(
+ FILES
+ initialization.h
+ command.h
+ selectcertificatecommand.h
+ signencryptfilescommand.h
+ DESTINATION ${INCLUDE_INSTALL_DIR}/libkleopatraclient/core
+ )
Index: b/kleopatra/libkleopatraclient/gui/CMakeLists.txt
===================================================================
--- a/kleopatra/libkleopatraclient/gui/CMakeLists.txt
+++ b/kleopatra/libkleopatraclient/gui/CMakeLists.txt
@@ -16,3 +16,9 @@ set_target_properties(kleopatraclientgui
)
install(TARGETS kleopatraclientgui ${INSTALL_TARGETS_DEFAULT_ARGS})
+
+install(
+ FILES
+ certificaterequester.h
+ DESTINATION ${INCLUDE_INSTALL_DIR}/libkleopatraclient/gui
+ )
Index: b/libkpgp/CMakeLists.txt
===================================================================
--- a/libkpgp/CMakeLists.txt
+++ b/libkpgp/CMakeLists.txt
@@ -33,3 +33,11 @@ add_subdirectory( tests )
install(FILES kpgp.upd DESTINATION ${KCONF_UPDATE_INSTALL_DIR})
install(PROGRAMS kpgp-3.1-upgrade-address-data.pl DESTINATION ${KCONF_UPDATE_INSTALL_DIR})
+install(FILES
+ kpgp.h
+ kpgpbase.h
+ kpgpblock.h
+ kpgpkey.h
+ kpgpui.h
+ libkpgp_export.h
+ DESTINATION ${INCLUDE_INSTALL_DIR}/kpgp COMPONENT Devel )
Index: b/libkleo/CMakeLists.txt
===================================================================
--- a/libkleo/CMakeLists.txt
+++ b/libkleo/CMakeLists.txt
@@ -112,6 +112,57 @@ endif(WIN32)
set_target_properties(kleo PROPERTIES VERSION ${GENERIC_LIB_VERSION} SOVERSION ${GENERIC_LIB_SOVERSION} )
install(TARGETS kleo ${INSTALL_TARGETS_DEFAULT_ARGS})
+install( FILES
+ kleo/kleo_export.h
+ kleo/enum.h
+ kleo/oidmap.h
+ kleo/cryptobackend.h
+ kleo/cryptobackendfactory.h
+ kleo/cryptoconfig.h
+ kleo/dn.h
+ kleo/job.h
+ kleo/keylistjob.h
+ kleo/keygenerationjob.h
+ kleo/abstractimportjob.h
+ kleo/importjob.h
+ kleo/importfromkeyserverjob.h
+ kleo/exportjob.h
+ kleo/changeexpiryjob.h
+ kleo/changeownertrustjob.h
+ kleo/downloadjob.h
+ kleo/deletejob.h
+ kleo/encryptjob.h
+ kleo/decryptjob.h
+ kleo/signjob.h
+ kleo/specialjob.h
+ kleo/verifydetachedjob.h
+ kleo/verifyopaquejob.h
+ kleo/decryptverifyjob.h
+ kleo/signencryptjob.h
+ kleo/signkeyjob.h
+ kleo/adduseridjob.h
+ kleo/refreshkeysjob.h
+ kleo/multideletejob.h
+ kleo/hierarchicalkeylistjob.h
+ kleo/keyfilter.h
+ kleo/keyfiltermanager.h
+ DESTINATION ${INCLUDE_INSTALL_DIR}/kleo COMPONENT Devel)
+
+install ( FILES
+ ui/kdhorizontalline.h
+ ui/messagebox.h
+ ui/progressbar.h
+ ui/progressdialog.h
+ ui/keylistview.h
+ ui/keyselectiondialog.h
+ ui/keyrequester.h
+ ui/keyapprovaldialog.h
+ ui/dnattributeorderconfigwidget.h
+ ui/cryptoconfigmodule.h
+ ui/cryptoconfigdialog.h
+ ui/directoryserviceswidget.h
+ DESTINATION ${INCLUDE_INSTALL_DIR}/kleo/ui COMPONENT Devel)
+
if ( WIN32 )
install ( FILES libkleopatrarc-win32.desktop DESTINATION ${CONFIG_INSTALL_DIR} RENAME libkleopatrarc )
else ( WIN32 )
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
