-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113699/#review43227
-----------------------------------------------------------


This review has been submitted with commit 
57dded0f4ef804807c168dedcda0da2765ea274c by Pali Rohár on behalf of Harsh Kumar 
to branch master.

- Commit Hook


On Nov. 7, 2013, 7:34 a.m., Harsh Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113699/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 7:34 a.m.)
> 
> 
> Review request for Kopete.
> 
> 
> Repository: kopete
> 
> 
> Description
> -------
> 
> cpp files made to include their own headers first. This helps in making these 
> headers standalone.
> 
> Fixes issue flagged by krazy2
> http://ebn.kde.org/krazy/reports/kde-4.x/kdenetwork/kopete/index.html
> 
>  libkopete/avdevice/videodevice.cpp           | 3 ++-
>  libkopete/avdevice/videodevicepool.cpp       | 3 ++-
>  libkopete/chatsessionmemberslistmodel.cpp    | 2 +-
>  libkopete/connectionmanager.cpp              | 4 ++--
>  libkopete/contactlist/xmlcontactstorage.cpp  | 2 +-
>  libkopete/kopeteaccount.cpp                  | 3 ++-
>  libkopete/kopeteidentity.cpp                 | 2 +-
>  libkopete/kopetemessage.cpp                  | 3 ++-
>  libkopete/kopetemessageevent.cpp             | 3 ++-
>  libkopete/kopetepassword.cpp                 | 2 +-
>  libkopete/kopetetransfermanager.cpp          | 4 ++--
>  libkopete/kopeteutils.cpp                    | 3 ++-
>  libkopete/managedconnectionaccount.cpp       | 4 ++--
>  libkopete/tests/kopetecontactlist_test.cpp   | 2 +-
>  libkopete/tests/kopetemessage_test.cpp       | 3 ++-
>  libkopete/tests/kopetepropertiestest.cpp     | 4 ++--
>  libkopete/tests/kopetetask_test.cpp          | 2 +-
>  libkopete/tests/kopetewallettest_program.cpp | 3 ++-
>  libkopete/tests/template_test.cpp            | 2 +-
>  libkopete/ui/addressbooklinkwidget.cpp       | 3 ++-
>  libkopete/ui/addressbookselectorwidget.cpp   | 2 +-
>  libkopete/ui/addresseeitem.cpp               | 4 ++--
>  libkopete/ui/collapsiblewidget.cpp           | 2 +-
>  libkopete/ui/kopetelistviewitem.cpp          | 2 +-
>  libkopete/ui/metacontactselectorwidget.cpp   | 3 ++-
>  25 files changed, 40 insertions(+), 30 deletions(-)
> 
> 
> Diffs
> -----
> 
>   libkopete/avdevice/videodevice.cpp 9ee0786 
>   libkopete/avdevice/videodevicepool.cpp cb55f87 
>   libkopete/chatsessionmemberslistmodel.cpp 9d8ee99 
>   libkopete/connectionmanager.cpp 57d35ea 
>   libkopete/contactlist/xmlcontactstorage.cpp 3912901 
>   libkopete/kopeteaccount.cpp 9e1fada 
>   libkopete/kopeteidentity.cpp 83aa2ea 
>   libkopete/kopetemessage.cpp ba187d4 
>   libkopete/kopetemessageevent.cpp 09509c7 
>   libkopete/kopetepassword.cpp b7ef639 
>   libkopete/kopetetransfermanager.cpp aac9472 
>   libkopete/kopeteutils.cpp 82b8667 
>   libkopete/managedconnectionaccount.cpp 9c17340 
>   libkopete/tests/kopetecontactlist_test.cpp 97a94f0 
>   libkopete/tests/kopetemessage_test.cpp 39a595f 
>   libkopete/tests/kopetepropertiestest.cpp 317ebb4 
>   libkopete/tests/kopetetask_test.cpp 6b5e4fd 
>   libkopete/tests/kopetewallettest_program.cpp 29d5bb3 
>   libkopete/tests/template_test.cpp 8598f79 
>   libkopete/ui/addressbooklinkwidget.cpp fbf15f8 
>   libkopete/ui/addressbookselectorwidget.cpp 936f5cd 
>   libkopete/ui/addresseeitem.cpp f6d4181 
>   libkopete/ui/collapsiblewidget.cpp 2e90b15 
>   libkopete/ui/kopetelistviewitem.cpp a330974 
>   libkopete/ui/metacontactselectorwidget.cpp 7f8be2a 
> 
> Diff: http://git.reviewboard.kde.org/r/113699/diff/
> 
> 
> Testing
> -------
> 
> Compiles & runs (Arch Linux)
> 
> 
> Thanks,
> 
> Harsh Kumar
> 
>

_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel

Reply via email to