On Wednesday 24 June 2015 13:40:51 Joshua Joseph wrote: > On Wed, Jun 24, 2015 at 1:25 PM, Pali Rohár <pali.ro...@gmail.com> wrote: > > > On Wednesday 24 June 2015 12:28:29 Joshua Joseph wrote: > > > On Wed, Jun 24, 2015 at 11:46 AM, Pali Rohár <pali.ro...@gmail.com> > > wrote: > > > > > > > On Wednesday 24 June 2015 11:40:14 Joshua Joseph wrote: > > > > > Hi > > > > > > > > > > On Mon, Jun 22, 2015 at 1:27 PM, Pali Rohár <pali.ro...@gmail.com> > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > Then post your interface for review and comments. > > > > > > > > > > > > See it here: > > > > > > > > > > > https://github.com/josh-wambua/kopete/blob/database_helper/plugins/history3/databasehelper.h > > > > > > > > > > > > > Ehm?? Wtf? > > > > > > > > class DatabaseHelper : public QObject { > > > > ... > > > > QList<Kopete::Message> search(Kopete::Contact *from); > > > > QList<Kopete::Message> search(Kopete::Contact *to); > > > > QList<Kopete::Message> search(Kopete::Contact *from, QDate date); > > > > QList<Kopete::Message> search(Kopete::Contact *to, QDate date); > > > :/ > > > > > ... > > > > }; > > > > > > > > Thought overloading search() would make it easier to work with. What do > > > you suggest? > > > > > > > Its not possible to do such that. Four functions and two of them have > > *same* arguments. > > > > Yes I've seen that. Now I'm changing it. >
So, fix all such problems... until that I'm not going to read more code. -- Pali Rohár pali.ro...@gmail.com _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
