> On March 13, 2016, 11:12 a.m., Pali Rohár wrote: > > Hi! Looks like that your patch does not fix this problem. Add Account > > dialog for yahoo protocol is still affected also after applying your patch
That's weird, the dialog's size is correctly adjusted here on every page change. Any way, after having played a lot with the code, and done some research, I believe I found the root of the problem. It all comes down to setting the word wrap property to QLabels. According to Qt's [documentation](http://doc.qt.io/qt-5/layout.html#layout-issues) and bug reports ([37673](https://bugreports.qt.io/browse/QTBUG-37673), [8212](https://bugreports.qt.io/browse/QTBUG-8212), [8740](https://bugreports.qt.io/browse/QTBUG-8740) and [41713](https://bugreports.qt.io/browse/QTBUG-41713)), setting a QLabel to word wrap mode will set its parent layouts in `QLayout::FreeResize` mode, which is why we can resize the New Account dialogs to just a few pixels. Disabling word wrap on the QLabel present in the New Account dialog for Yahoo, for example, fixes the bug. But if the strings can't be made shorter, it doesn't look like we can afford disabling word wrap. I'll keep searching. - Paulo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127358/#review93474 ----------------------------------------------------------- On March 13, 2016, 3:13 p.m., Paulo Lieuthier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127358/ > ----------------------------------------------------------- > > (Updated March 13, 2016, 3:13 p.m.) > > > Review request for Kopete and Pali Rohár. > > > Bugs: 166225 > http://bugs.kde.org/show_bug.cgi?id=166225 > > > Repository: kopete > > > Description > ------- > > When adding a new account, the wizard doesn't resize on page change, leading > to very thin text fields and labels, as shown in the referenced bug report. > The patch makes the wizzard have its size adjusted on chaging page. > > > Diffs > ----- > > kopete/addaccountwizard/addaccountwizard.cpp cc9fc8a > > Diff: https://git.reviewboard.kde.org/r/127358/diff/ > > > Testing > ------- > > > Thanks, > > Paulo Lieuthier > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
