----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130046/ -----------------------------------------------------------
Review request for Kopete, Pali Rohár and R.Harish Navnit. Repository: kopete Description ------- Removed kde3 and qt3 dependencies from oscar protocol. Removed certain header files. Adapted syntax for some functions and datatypes. Build Succeeds. Diffs ----- protocols/oscar/aim/aimaccount.h 1d8e290 protocols/oscar/aim/aimaccount.cpp ac8a28d protocols/oscar/aim/aimcontact.h f90fab0 protocols/oscar/aim/aimjoinchat.h 94514e1 protocols/oscar/aim/aimjoinchat.cpp ef47c40 protocols/oscar/aim/aimprotocol.cpp 662868a protocols/oscar/aim/aimuserinfo.h 1e386ac protocols/oscar/aim/aimuserinfo.cpp b284976 protocols/oscar/aim/icqcontact.h 6243d06 protocols/oscar/aim/icqcontact.cpp 2786b8e protocols/oscar/aim/ui/aimaddcontactpage.h 1120938 protocols/oscar/aim/ui/aimeditaccountwidget.h 74f278f protocols/oscar/aim/ui/aimeditaccountwidget.cpp 8eed38b protocols/oscar/icq/aimcontact.h c74ac5a protocols/oscar/icq/icqaccount.h 855a82b protocols/oscar/icq/icqcontact.h 9617304 protocols/oscar/icq/icqcontact.cpp efe9d4b protocols/oscar/icq/icqprotocol.cpp 075dfdd protocols/oscar/icq/icqreadaway.h 0ae0b8a protocols/oscar/icq/icqstatusmanager.cpp 476084a protocols/oscar/icq/ui/editorwithicon.h 662c55d protocols/oscar/icq/ui/editorwithicon.cpp b213fe3 protocols/oscar/icq/ui/iconcells.h a1ff4e9 protocols/oscar/icq/ui/iconcells.cpp ccae836 protocols/oscar/icq/ui/icqaddcontactpage.h 7a88577 protocols/oscar/icq/ui/icqauthreplydialog.cpp 56ba195 protocols/oscar/icq/ui/icqchangepassworddialog.h e836384 protocols/oscar/icq/ui/icqeditaccountwidget.h ec5ce4a protocols/oscar/icq/ui/icqsearchdialog.h 8610bfa protocols/oscar/icq/ui/icqsearchdialog.cpp 6b3e0e0 protocols/oscar/icq/ui/icquserinfowidget.h 559d01f protocols/oscar/icq/ui/icquserinfowidget.cpp e43f4ee protocols/oscar/icq/ui/xtrazicqstatuseditor.h fc1867b protocols/oscar/icq/xtrazstatusaction.h d790cef protocols/oscar/icq/xtrazstatusmodel.cpp 8c40879 protocols/oscar/icqcontactbase.h 438153e protocols/oscar/liboscar/chatroomhandler.h 73273b1 protocols/oscar/liboscar/client.h 7d03505 protocols/oscar/liboscar/client.cpp 635088a protocols/oscar/liboscar/connection.h cd4c2cd protocols/oscar/liboscar/connectionhandler.h 8a7add4 protocols/oscar/liboscar/connectionhandler.cpp 747f2af protocols/oscar/liboscar/contact.cpp fda19d0 protocols/oscar/liboscar/contactmanager.h 214c309 protocols/oscar/liboscar/contactmanager.cpp d36fdd3 protocols/oscar/liboscar/coreprotocol.h 1efe621 protocols/oscar/liboscar/coreprotocol.cpp dfac90b protocols/oscar/liboscar/flapprotocol.cpp 11cc6a5 protocols/oscar/liboscar/inputprotocolbase.h 24f5f0f protocols/oscar/liboscar/oftmetatransfer.h d95e5af protocols/oscar/liboscar/oftmetatransfer.cpp f106d15 protocols/oscar/liboscar/oftprotocol.cpp 43d5183 protocols/oscar/liboscar/ofttransfer.cpp 8404b83 protocols/oscar/liboscar/oscarmessage.cpp 13aed5e protocols/oscar/liboscar/oscartypeclasses.h 2292f3b protocols/oscar/liboscar/oscartypes.h 98844e2 protocols/oscar/liboscar/rateclass.h 1069a18 protocols/oscar/liboscar/rateclassmanager.h 10f09ec protocols/oscar/liboscar/safedelete.h c41b131 protocols/oscar/liboscar/safedelete.cpp 39f79b4 protocols/oscar/liboscar/snacprotocol.cpp a230c92 protocols/oscar/liboscar/stream.h 0665fd1 protocols/oscar/liboscar/tasks/buddyicontask.h 2a13b5f protocols/oscar/liboscar/tasks/buddyicontask.cpp a9f3943 protocols/oscar/liboscar/tasks/chatnavservicetask.h 0e8af88 protocols/oscar/liboscar/tasks/chatroomtask.h 86a9142 protocols/oscar/liboscar/tasks/chatservicetask.h a021c66 protocols/oscar/liboscar/tasks/chatservicetask.cpp 94abbd1 protocols/oscar/liboscar/tasks/closeconnectiontask.cpp d469146 protocols/oscar/liboscar/tasks/errortask.h c612bc2 protocols/oscar/liboscar/tasks/filetransfertask.h a0a73fb protocols/oscar/liboscar/tasks/filetransfertask.cpp 61f51d6 protocols/oscar/liboscar/tasks/icqtask.cpp fd95e15 protocols/oscar/liboscar/tasks/icquserinfotask.h 6397e0e protocols/oscar/liboscar/tasks/icquserinfoupdatetask.cpp 44a8ad2 protocols/oscar/liboscar/tasks/logintask.h e20ef51 protocols/oscar/liboscar/tasks/logintask.cpp 1c9acb9 protocols/oscar/liboscar/tasks/messageacktask.h a933324 protocols/oscar/liboscar/tasks/messagereceivertask.h 7f0d47b protocols/oscar/liboscar/tasks/messagereceivertask.cpp b25a3e3 protocols/oscar/liboscar/tasks/onlinenotifiertask.h 51aa0ab protocols/oscar/liboscar/tasks/oscarlogintask.h 73b4299 protocols/oscar/liboscar/tasks/ownuserinfotask.h 1682ffb protocols/oscar/liboscar/tasks/profiletask.cpp 25df9a8 protocols/oscar/liboscar/tasks/rateinfotask.h 37ecae5 protocols/oscar/liboscar/tasks/sendmessagetask.h 10649f7 protocols/oscar/liboscar/tasks/sendmessagetask.cpp 3d68917 protocols/oscar/liboscar/tasks/serverredirecttask.h 9684b28 protocols/oscar/liboscar/tasks/servicesetuptask.h c5bf5a7 protocols/oscar/liboscar/tasks/ssiauthtask.h 4e32d81 protocols/oscar/liboscar/tasks/ssilisttask.h 9af5535 protocols/oscar/liboscar/tasks/ssimodifytask.cpp 4d6d9a4 protocols/oscar/liboscar/tasks/task.h 00a2c3c protocols/oscar/liboscar/tasks/task.cpp f460fa9 protocols/oscar/liboscar/tasks/typingnotifytask.h 160bd98 protocols/oscar/liboscar/tasks/typingnotifytask.cpp dcbdae0 protocols/oscar/liboscar/tasks/userinfotask.h c119db1 protocols/oscar/liboscar/tasks/usersearchtask.h 248aadd protocols/oscar/liboscar/tasks/warningtask.h 4edb88d protocols/oscar/liboscar/tasks/warningtask.cpp c131aa9 protocols/oscar/liboscar/tests/aimlogintasktest.h 0bdc303 protocols/oscar/liboscar/tests/buffertest.h 4e52f7a protocols/oscar/liboscar/tests/filetransfertest.h 54259f5 protocols/oscar/liboscar/tests/guidtest.h 3fbf897 protocols/oscar/liboscar/tests/logintest.h 580ff20 protocols/oscar/liboscar/tests/logintest.cpp d2c468b protocols/oscar/liboscar/tests/rateinfotest.h 5633728 protocols/oscar/liboscar/tests/serverversionstest.h 7a4158a protocols/oscar/liboscar/userdetails.cpp 535b6e5 protocols/oscar/liboscar/utils/rtf2html.h a305b89 protocols/oscar/oscaraccount.h 471ddd3 protocols/oscar/oscaraccount.cpp 73e1127 protocols/oscar/oscarcontact.h 7ada939 protocols/oscar/oscarcontact.cpp 8ed1215 protocols/oscar/oscarencodingselectiondialog.h 32d0754 protocols/oscar/oscarlistnonservercontacts.h 7626953 protocols/oscar/oscarlistnonservercontacts.cpp d011368 protocols/oscar/oscarmyselfcontact.h fbeae08 protocols/oscar/oscarprivacyengine.h 6bbacf4 protocols/oscar/oscarstatusmanager.cpp 9154e57 protocols/oscar/oscarversionupdater.h 2e6b9e7 Diff: https://git.reviewboard.kde.org/r/130046/diff/ Testing ------- Thanks, Vijay Krishnavanshi
