> On June 10, 2017, 1:26 p.m., Laurent Montel wrote: > >
I had already started translating those (and all others) in my main branch, and didn't want to mess with that here. Next review request will be such translation, isn't that better? By the way, I does it mean to "`kDebug(14308)`" (there is a lot of that in the codebase). Where does that number come from? Is it the category? Then qCDebug should be used, then? - Paulo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130154/#review103302 ----------------------------------------------------------- On June 10, 2017, noon, Paulo Lieuthier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130154/ > ----------------------------------------------------------- > > (Updated June 10, 2017, noon) > > > Review request for Kopete, Laurent Montel and Pali Rohár. > > > Repository: kopete > > > Description > ------- > > The history plugin port was not completed, so it is disabled. This patch > re-enables it, fixes it's building failures and fixes not saving the history > file when the directory doesn't exist. > > Pull from here: > https://github.com/paulolieuthier/kopete/commits/fix-history-plugin. > > > Diffs > ----- > > libkopete/ui/kopeteview.h 070a3b8a2 > plugins/CMakeLists.txt 6216058ef > plugins/history/CMakeLists.txt ce90b84a3 > plugins/history/converter.cpp 3175beac1 > plugins/history/historyguiclient.cpp 41745bfe0 > plugins/history/historylogger.cpp 66b627030 > plugins/history/historyplugin.cpp 48cd98010 > plugins/history/historypreferences.cpp 9c64b4418 > > Diff: https://git.reviewboard.kde.org/r/130154/diff/ > > > Testing > ------- > > Tested last messages appearance on reopening a chat window, using Jabber and > Test Protocol. > > > Thanks, > > Paulo Lieuthier > >
