> Date: Thu, 04 Dec 2008 06:15:08 +0100
> From: Roland Mainz <roland.mainz at nrubsig.org>
>
> James Carlson wrote:
> >
> > Some general issues:
> >
> > The libraries look like they need some additional TLC. I'm guessing
> > that *might* be something on a future development path, but if not,
> > then I'll flag some of those issues here.
>
> What is "TLC" ?
TLC is "tender, loving care"
...
>
> > usr/src/Makefile.ast
...
> >
> > 67: I'm not sure I know the importance of this change. April (or
> > someone else associated with the project) should look into the
> > legal issues to make sure that this name change doesn't cause
> > trouble.
>
> April already asked the lawyers long ago, AFAIK it was "ok" ...
> ... April ?
I am waiting for a response from legal on this change in copyright,
from "AT&T Knowledge Ventures" to "AT&T Intellectual Property".
This seems like a simple name change from AT&T, but it's better
to double check.
...
>
> > usr/src/Makefile.ksh93switch
> >
> > There are no substantive changes here. Is this part of the review?
>
> Technically we only updated the CDDL stuff since the file is part of the
> project.
We don't need to touch this file, since the only changes are
to update the copyright year to 2008 (not necessary, since there
are no changes) and remove the ident line (we don't need to do this
if we're not making other changes to the file). CDDL isn't changed in
this file, although for the usr/src/lib/libcmd/<arch>/Makefile changes,
we don't need to touch these files either, just to update the CDDL.
...
>
> > usr/src/lib/libsum/THIRDPARTYLICENSE
> >
> > Not an issue for my review, but someone should make sure that this
> > new license gets packaged and delivered properly.
>
> Uhm... what do you mean with that ?
>
> > usr/src/lib/libsum/THIRDPARTYLICENSE.descrip
> >
> > This description doesn't seem to match the license itself. The
> > license itself seems to be "CPL" with IBM as a "steward" (serving
> > soft drinks and peanuts, I guess). This description says AT&T,
> > which appears nowhere in the license itself. What gives?
>
> Uhm... April: ping!
>
> AFAIK the license was invented by "IBM" and AT&T uses it... but the
> other stuff is something only the legal folks can explain...
The AT&T source and binaries have been released under CPL 1.0.
This THIRDPARTYLICENSE text for CPL 1.0
comes directly from a link to the license from AT&T:
http://www.research.att.com/sw/download/
The license text was included in open source reviews approved
by legal in 2006 and 2007. I don't know about the IBM stewardship,
but apparently since CPL 1.0 comes from the Open Source Initiative,
this license is used by other open source software, not just software
from AT&T.
The THIRDPARTYLICENSE for libsum is identical to the one used for
the rest of the AT&T software already integrated, and the libsum
THIRDPARTYLICENSE.descrip file follows the same format as the others as well.
April
