Roland Mainz wrote:
> Roland Mainz wrote:
> > April Chin wrote:
> [snip]
> > > ./lib/libast/common/misc/optctx.c
> >
> > These five can AFAIK be removed ("optctx.c" is a valid source file but I
> > forgot to hook it up in Makefile.com ... but nothing in the current
> > OS/Net codebase uses it and to make this issue short: remove it
> > (otherwise we need a reviewer for the one-liner and I doubt any of the
> > reviewers is still around)).
>
> Ahhggrrlrlll... this issue is so... <censored>> (my fault). The problem
> works like this:
> Somehow during a source rename something went wrong and "optctx.c" was
> accidently called "optoptctx.c". That's why "optctx.c" shows-up as
> unreferenced and optoptctx.c doesn't exist in the upstream sources but
> has the CPL license. Grrr.... this is so... <censored>.
>
> I've attached the fix for this as
> "ksh93_integration_optoptctx_rename001.diff.txt" - it removes the
> "optoptctx.c" file which is identical to "optctx.c" (therefore no extra
> review required for this file) and adjusts
> usr/src/lib/libast/Makefile.com to use the correct source...
John: John Smith <woocky at mailinater.com> and C. Bergstr?m
<cbergstrom at netsyncro.com> reviewed the change... I hope that's Ok for
the RTI (the patch doesn't change any real code since "optoptctx.c" and
"optctx.c"'s code is identical. The patch still passes the
ksh93-integration test suite in the "C", "en_US.UTF-8" and
"zh_CN.GB18030" locales and basic interactive tests work, too).
----
Bye,
Roland
--
__ . . __
(o.\ \/ /.o) roland.mainz at nrubsig.org
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL +49 641 3992797
(;O/ \/ \O;)
-------------- next part --------------
An embedded message was scrubbed...
From: John Smith <[email protected]>
Subject: Re: [ksh93-integration-discuss] "optoptctx.c" vs. "optctx.c" ... /
was: Re: unreferenced files
Date: Wed, 24 Dec 2008 05:36:13 PST
Size: 3159
URL:
<http://mail.opensolaris.org/pipermail/ksh93-integration-discuss/attachments/20081224/d42e32fd/attachment.nws>
-------------- next part --------------
An embedded message was scrubbed...
From: =?UTF-8?Q?C=2E_Bergstr=C3=B6m?= <[email protected]>
Subject: Re: [ksh93-integration-discuss] "optoptctx.c" vs. "optctx.c" ... /
was: Re: unreferenced files
Date: Wed, 24 Dec 2008 05:49:36 PST
Size: 3214
URL:
<http://mail.opensolaris.org/pipermail/ksh93-integration-discuss/attachments/20081224/d42e32fd/attachment-0001.nws>
