On 11/29/08, April Chin <April.Chin at sun.com> wrote:
> I am requesting code review of the update of ksh93 to
> ksh93t 2008-11-04 for OpenSolaris contributor Roland Mainz
> (roland.mainz at nrubsig.org).
> We'd like to receive review comments by Friday, December 5.
>
> The review is broken into two parts.
>
> The webrev for the changes to the AT&T files for ksh93 and its libraries,
> for the update to ast-base version 2008-11-04 is at:
>
> http://cr.opensolaris.org/~chin/ksh93-update1.ast
>
> The webrev for all of the other (non-AST) files, including Makefile
> and packaging changes, is at:
>
> http://cr.opensolaris.org/~chin/ksh93-update1.non-ast
>
> The changes implement the following ARC cases:
>
> http://www.opensolaris.org/os/community/arc/caselog/PSARC/2008/094
> ksh93 Update 1
> http://www.opensolaris.org/os/community/arc/caselog/PSARC/2008/344
> ksh93 Integration Update 1 Amendments 1
>
> and fix the bugs below (see the webrev for links to the bugs).
>
> These bugs/RFEs are fixed by the non-AST changes:
>
> 6619428 RFE: Update ksh93 in Solaris to ast-ksh.2008-11-04 (or higher)
> 6561901 RFE: Add "shcomp" (shell script compiler) + kernel module to exec
> binary
> sh code
> 6599668 *ksh93* RFE: Move consumers of alias.sh over to ksh93
> 6595183 RFE: Update ksh93-integration demo code
> 6775901 *ksh93* no C message catalogs are generated for ksh93
> 6451262 *sleep* RFE: /usr/bin/sleep should support floating-point values
>
> These bugs are fixed by the AST changes:
>
> 6687139 *ksh93* command substitution, exec, and stdout redirection cause
> allocation loop
> 6703761 *ksh* ksh crashes in script containing uncommon output redirections
> 6715496 ksh93 SEGVs on array reinitialization
> 6713682 Creating a compound variable in a subshell "bleeds through" to the
> calling subshell
> 6672350 ksh93 causes parent shell to die when child shell is suspended
> 6745015 *ksh93* VARIABLE=`command substitution` assignment is not reliable on
> OpenSolaris
> 6710205 *ksh93* problem with command substitution (within back quotes)
> containing \$'
> 6737600 ksh93 exits debugger when user presses ctrl-c
> 6748645 *ksh93* fc -l -e - is mis-parsed, outputs wrong error message "-e -
> requires single argument"
> 6754020 ksh93 does weird '[' expansion
> 6753538 umask modification leaks out of a ksh93 subshell
> 6687139 *ksh93* command substitution, exec, and stdout redirection cause
> allocation loop
> 6766246 *ksh93* bug in pattern matching
> 6763594 *ksh93* executes command after "command" builtin twice on failure
>
> There may be two more ksh93 bugs added to the above list,
> but we are in the process of obtaining verification that
> the bugs in question are indeed fixed by ksh93t 2008-11-04.
>
> Thanks in advance for your help.
Hi April and Roland,
I've reviewed the previous webrevs and the changes look good to me.
Few questions out of curiosity:
usr/src/lib/libast/common/llib-last
Was this file build by hand or script?
usr/src/uts/common/exec/shbin/shbin.c
What is the purpose of /sbin/ksh93?
Jenny
---
Jennifer Pioch, Uni Frankfurt
