John Plocher wrote:
> Keith M Wesolowski wrote:
>>> On Thu, Mar 08, 2007 at 04:03:19AM +0100, Roland Mainz wrote:
>>> Grumpf...
>> Am I correct in thinking that your concerns around removing these
>> files are entirely a result of a belief that the structure of the code
>> should be optimised for bulk upgrades from an external source base?
> 
> 
> It sounds like there is/will/reallyshouldbe two different blobs of
> code in the source tree:
> 
>     The baseline ATT sources, exactly as delivered by ATT
> 
>     and
> 
>     A derived set of OpenSolaris source files
> 
> 
> In much the same way that we generate C sources via rpcgen, the
> ksh93 build process could [diff/patch, rename, exclude, etc] the
> files found in the baseline tree to create the OpenSolaris-specific
> source tree.  And then build that tree.

No.
No no no no no.
No.

This is not analogous to rpcgen, this is patching a fairly large component 
into the ON world *at build time*.  Such that we don't actually have the 
sources we build in the tree at all, but instead have the original sources 
and a collection of hard to maintain, impossible to cscope, impossible to 
opengrok patches and scripts to perturb them into buildable form as part of 
the build.

This is work that should be done prior to integration, with only the results 
being integrated.  In fact, this is work Roland *has* done prior to 
integration, what we're discussing is the "with only the results..." part.

Did I say No already?
Please.  No.

-- Rich

Reply via email to