> Date: Sun, 15 Jul 2007 23:10:02 -0700 (PDT)
> From: David.Comay at sun.com
> Subject: Re: final ksh93 code review, round three
> To: April Chin <April.Chin at sun.com>
> Cc: ksh93-integration-discuss at opensolaris.org, peter.memishian at sun.com,
craig.mohrman at sun.com, james.d.carlson at sun.com, roland.mainz at
nrubsig.org
> MIME-version: 1.0
> Content-transfer-encoding: 7BIT
> X-PMX-Version: 5.2.0.264296
>
> > FULL WEBREVS
>
> > Non-AST files:
> > http://cr.grommit.com/~chin/ksh93-webrev-jul13/jul13-nonattfiles
>
> I only have one remaining comment.
>
> usr/src/lib/libshell/common/tests/sun_solaris_getconf.sh
>
> Line 32 - s/compatibilty/compatibility/
>
> (I just happen to see that but otherwise did not check these
> scripts in detail. You might want to spell check the comments
> in all of the new non-ATT files just to make sure.)
Thanks...spell check came up with 4 more typos we'll fix:
./src/cmd/ksh/Makefile.com:54:# way to expliclity list each single flag.
^^^^^^^^^^
explicitly
./src/lib/Makefile.asthdr:86:# Add temprary include files to the list of files
to "clobber"
^^^^^^^^
temporary
./src/lib/libshell/common/tests/sun_solaris_getconf.sh:32:#
sun_solaris_getconf.sh - test the ksh93 getconf builtin for compatibilty
^^^^^^^^^^^^
compatibility
./src/lib/libc/port/regex/wordexp.c:86: * return s1-1 (position of string
terminator ('\0') in destnation buffer).
^^^^^^^^^^
destination
Thanks,
April
>
> dsc
