Alan Coopersmith wrote: > Roland Mainz wrote: > > As said I can remove them for the Makefiles+code we "own" now and the > > others as late as possible since the "ident" stuff is the _major_ source > > of bitrot. I don't want to play the "catch the ident changes"-game over > > and over again since the time for that comes from my almost non-existing > > chunk of free time... > > Are you saying the ident lines in question are in the upstream source, not > Sun added?
No, no... I was thinking about the Makefiles, code, test suite modules (e.g. we now try to create a seperate test suite module for each bug filed in bugster, for example http://svn.genunix.org/repos/on/branches/ksh93/gisburn/prototype012/usr/src/lib/libshell/common/tests/sun_solaris_cr_6713682_compound_var_bleeds_through_subshell.sh is one of these things) etc. in usr/src/lib/lib(shell|cmd|dll|sum|pp|ast)/, usr/src/cmd/ksh/ etc. which are Sun-specific. AST upstream doesn't use "ident" lines... > If so, then leaving them in permanently and having the ON CRT > waive their removal is the only sane choice. Upstream code should always > be exempt from style and formatting rules such as ident removal and cstyle, > since otherwise every update is an exercise in pointless time wasting. I know... ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 3992797 (;O/ \/ \O;)
