> X-Original-To: ksh93-integration-discuss at opensolaris.org
> Delivered-To: ksh93-integration-discuss at opensolaris.org
> Date: Fri, 23 Feb 2007 12:25:54 -0700
> From: Bonnie Corwin <Bonnie.Corwin at Sun.COM>
> Subject: Re: Minor legal questions about
usr/src/lib/libshell/common/data/builtins.c ... / was: Re:
[ksh93-integration-discuss] Re: [osol-code] Round two:((pre-)pre-review)
ksh93-integrationwebrev 2007-02-02
> To: David.Comay at Sun.COM, Roland Mainz <roland.mainz at nrubsig.org>
> MIME-version: 1.0
> Content-transfer-encoding: 7BIT
> X-Accept-Language: en-us, en
> User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.7) Gecko/20060629
> Cc: Korn Shell 93 integration/migration project discussion
<ksh93-integration-discuss at opensolaris.org>, Alan Burlison
<Alan.Burlison at Sun.COM>, OpenSolaris Code mailing list
<opensolaris-code at opensolaris.org>
> X-BeenThere: ksh93-integration-discuss at opensolaris.org
> X-Mailman-Version: 2.1.4
> List-Id: Korn Shell 93 integration/migration project discussion
<ksh93-integration-discuss.opensolaris.org>
> List-Unsubscribe:
<http://mail.opensolaris.org/mailman/listinfo/ksh93-integration-discuss>,
<mailto:ksh93-integration-discuss-request at
opensolaris.org?subject=unsubscribe>
> List-Archive:
<http://mail.opensolaris.org/pipermail/ksh93-integration-discuss>
> List-Post: <mailto:ksh93-integration-discuss at opensolaris.org>
> List-Help:
<mailto:ksh93-integration-discuss-request at opensolaris.org?subject=help>
> List-Subscribe:
<http://mail.opensolaris.org/mailman/listinfo/ksh93-integration-discuss>,
<mailto:ksh93-integration-discuss-request at opensolaris.org?subject=subscribe>
>
> David.Comay at sun.com wrote:
> >> AFAIK the only remaining question is whether the following change to the
> >> AT&T source file "builtins.c"
> >>
(http://www.nrubsig.org/people/gisburn/work/solaris/ksh93_integration/ksh93_inte
gration_prototype004_webrev_20070210/allfiles/webrev/usr/src/lib/libshell/common
/data/builtins.c.html)
> >>
> >> requires that we have to put a CDDL license at the top of that file:
> >
> >
> > Actually, I don't think that's what needs to be asked.
> >
> > What I suggested asking Bonnie about was whether or not this change
> > requires a Sun copyright to be added. I don't believe adding a CDDL
> > block to the ATT code is appropriate but for ON, we typically add a Sun
> > copyright to files with "significant" change. In my book, significant
> > includes changes necessary to get the file to actually compile but
> > others may disagree.
>
> Re: adding a Sun copyright: there are no hard and fast rules. When
> working with third-party projects, we should try to adhere to the
> culture of that project. And often, copyrights are not added unless the
> change is deemed significant in terms of size or complexity. Most of
> the people I have talked with in the past have suggested being
> conservative in this arena (i.e., only add a Sun copyright for something
> truly substantive).
>
> FYI, I think part of the confusion in this discussions stems from
> decisions that have previously been made within Sun about adding
> copyrights and updating the year in a copyright. To keep things
> completely simple wrt to process instructions, 'significant' changes are
> defined as changes that result in a change to the object code and
> changes to comments that are significant enough to be considered
> documentation.
>
> Bottom line - the project members should make a call.
Although this change is "significant" according to the
above definition (it would alter the object code),
I would prefer that we not add a Sun copyright to the AT&T file
builtins.c for this very minor change to include a Solaris-specific header
file. We should try to minimize the changes
to the AT&T files, unless absolutely necessary.
In any case, with the recently-proposed upstream change to builtins.c
from Glenn Fowler, we may no longer need to make the change at all,
so there would no longer be a copyright issue.
>
> Re: adding the CDDL. As Roland notes, the outbound OSR allows us to
> contribute OpenSolaris code to the ksh93 project using the CPL. No need
> to put the CDDL on anything.
>
> Sorry for the delay in responding - hope this helps a little.
Thanks, Bonnie!
April
>
> Bonnie
> _______________________________________________
> ksh93-integration-discuss mailing list
> ksh93-integration-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/ksh93-integration-discuss
