Bonnie Corwin wrote: > David.Comay at sun.com wrote: [snip] > FYI, I think part of the confusion in this discussions stems from > decisions that have previously been made within Sun about adding > copyrights and updating the year in a copyright. To keep things > completely simple wrt to process instructions, 'significant' changes are > defined as changes that result in a change to the object code and > changes to comments that are significant enough to be considered > documentation.
Problem is that the added |#include| is AFAIK a border case... the change itself to the source file is IMO not significant but it includes a header containing a fixed list of builtin commands (defined by PSARC 2006/550) which are enabled by default which is significant. The idea of using an |#include|-statement+seperate header (instead of adding the code directly) was do avoid the need to add something like CDDL and/or a copyright to the ksh93 sources which would bloat the patch significantly (e.g. I am seeing this from the technical viewpoint...). Anyway... ... Glenn added a hook in the ksh93 code to avoid any patches which means we do not hit this issue for this round (which means we do not need the *.diff files in this case (and more or less forward that "fight" to the next case where it may be needed...)). > Bottom line - the project members should make a call. Do you mean "phone call" ? > Re: adding the CDDL. As Roland notes, the outbound OSR allows us to > contribute OpenSolaris code to the ksh93 project using the CPL. No need > to put the CDDL on anything. Ok... what about adding the "Sun copyright" ... can that be avoided by using the "OSR" ? > Sorry for the delay in responding - hope this helps a little. Thanks for the answers... :-) ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 7950090 (;O/ \/ \O;)
