> Date: Mon, 26 Feb 2007 12:10:50 -0800 (PST)
> From: April Chin <April.Chin at eng.sun.com>
> Subject: Re: unreferenced files exception_list was Re: [osol-code] Round
two:((pre-)pre-review)ksh93-integrationwebrev2007-02-02
> To: April.Chin at eng.sun.com, danek.duvall at sun.com
> Cc: richlowe at richlowe.net, roland.mainz at nrubsig.org,
onnv-unref at onnv.sfbay.sun.com, ksh93-integration-discuss at opensolaris.org
> MIME-Version: 1.0
> Content-MD5: O7CSMZyEBQo2h2lxVgP9pg==
>
>
> > Date: Mon, 26 Feb 2007 12:02:41 -0800
> > From: Danek Duvall <danek.duvall at sun.com>
> > To: April Chin <April.Chin at eng.sun.com>
> > Cc: richlowe at richlowe.net, roland.mainz at nrubsig.org,
> onnv-unref at onnv.sfbay.sun.com, ksh93-integration-discuss at opensolaris.org
> > Subject: Re: unreferenced files exception_list was Re: [osol-code] Round
> two:((pre-)pre-review)ksh93-integrationwebrev2007-02-02
> > Mime-Version: 1.0
> > Content-Disposition: inline
> > User-Agent: mutt-ng/devel-r535 (SunOS)
> >
> > Redirecting to onnv-unref, which is gk + meem. :)
> >
> > On Mon, Feb 26, 2007 at 11:46:46AM -0800, April Chin wrote:
> >
> > > > From: Richard Lowe <richlowe at richlowe.net>
> > > >
> > > > I assume because you updated exception lists or the like?
> > >
> > > Actually, version 619, from which I downloaded Roland's workspace,
> > > does NOT have any changes to usr/src/tools/findunref/exception_list;
> > > however, the following new entries have been recently added to the latest
> > > usr/src/tools/findunref/exception_list, which, according to the comments
> > > in the file, require gatekeeper approval:
> > >
> > > # ident "@(#)exception_list 1.76 06/09/13 SMI"
> > > @@ -53,11 +53,18 @@
> > > #
> > > # Ignore everything under trees that may be resynched from outside ON.
> > > #
> > > +./src/cmd/ast
> > > +./src/cmd/ksh
> > > ./src/cmd/perl
> > > ./src/cmd/svc/configd/sqlite
> > > ./src/cmd/tcpd
> > > ./src/common/openssl
> > > ./src/grub
> > > +./src/lib/libast
> > > +./src/lib/libcmd
> > > +./src/lib/libdll
> > > +./src/lib/libpp
> > > +./src/lib/libshell
> > > ./src/uts/intel/sys/acpi
> > >
> > > I'm therefore cc-ing the gatekeepers alias for this...
> > >
> > > >
> > > > Otherwise I can't see how that would be the case, given that we *know*
> some
> > > > of the files being introduced are unreferenced by the build...
> > >
> > > Yes, this was puzzling to us as well--neither I nor Roland saw
> > > anything listed for "unreferenced files" for our nightly builds
> > > (with -f option) based on his workspace.
> >
> > Yeah, well, that'll do it. I'm not thrilled by the blanket coverage, even
> > with the obvious precedents. How many unref files do you actually have if
> > you remove these entries from the exception list?
>
> Well, as far as what nightly -f reported, there were none...which
> is strange, since we thought the files being discussed during
> the pre-codereview would have been listed. Note that these are nightly
> builds *without* the above-listed exception_list change.
> I believe the files mentioned would have been less than a dozen files.
Okay, sorry I'm way off on this number...
I just reran a nightly build with the all the new files correctly "wx created".
The sparc build has > 600 unreferenced files for ksh93, x86-specific files
make up 400 of those. So yes, we really do need the exception_list entries.
Thanks,
April
>
> April
> >
> > Danek
>
