Jim Walker wrote at Sun Oct 18 2009 23:50:42 GMT-0700 (PDT): > UVR wrote: >> >> A webrev of the STC ksh93 test suite has been posted at >> http://cr.opensolaris.org/~uvr/stf-ksh93test-webrev/ >> for your consideration and review. This 'test suite' is >> an execution mechanism for the official ksh93 'demo' tests >> (/usr/demo/ksh/tests) using the STF test harness. > > Looks good. Just a few nits:
Thanks for your feedback, Jim. > usr/src/suites/os/ksh93/README > - check the wording "ahe" and SUT (System Under Test) should be defined: > 65 utility (package: SUNWstc-checkenv); it must also be installed > locally on > 66 ahe SUT or accessible over NFS. The SUNWstc-stf and SUNWstc-checkenv "ahe" should be "the" (obviously). Will fix. SUT is already defined at line 57 in the immediately preceding paragraph of the same section of the README file. > - what about the os.o onnv-gate location for the README.tests file? > - why isn't the README.tests file there? I don't know why the file isn't in the onnv-gate. It's my opinion that it should be. > Are the tests up-to-date? > http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/lib/libshell/common/tests/ > 237 http://svn.genunix.org/repos/on/branches/ksh... In the onnv-gate the tests are *not* up to date (yet). The most recent tests should get integrated when the ksh93 update2 code pushes. I've been running the tests from the ksh93-update2 tarball dated Sep 22, 2009. However, note that the actual state of the tests (up to date or not) is immaterial to this STF test suite. The scripts provided here will run what(ever) tests exist in /usr/demo/ksh/tests. The purpose of this test suite is not to add or update any actual ksh tests, but rather only to provide an STC-compliant execution mechanism for the tests that exist in /usr/demo/ksh/tests. > usr/src/suites/os/ksh93/bin/runtests.ksh > - is the onnv-gate the correct location? > 67 # This test is based on the testshell target of Makefile.testshell > located in > 68 # onnv-gate at usr/src/cmd/ksh/Makefile.testshell Yes, the location is correct -- http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/cmd/ksh/Makefile.testshell > usr/src/suites/os/ksh93/README > usr/src/suites/os/ksh93/Makefile > - add a blank comment line after line 26 > 24 # Use is subject to license terms. > 25 # > 26 # ident "@(#)Makefile 1.4 09/10/16 SMI" > 27 Will fix. > usr/src/suites/os/ksh93/bin/runtests.ksh > usr/src/suites/os/ksh93/tests/gentests.ksh > - add a blank comment line before the Copyright block on line 23: > 22 > 23 # Copyright 2009 Sun Microsystems, Inc. All rights reserved. > 24 # Use is subject to license terms. Will fix. Thanks, -Ravindra.
