You remove usr/src/Makefile.ksh93switch but I cannot find the place where you set WORDEXP_KSH93=1 for usr/src/lib/libc/port/regex/wordexp.c. Can you point me to the place where you do this, please?
On Sat, Nov 21, 2009 at 11:19 PM, Richard Lowe <richlowe at richlowe.net> wrote: > "Mark J. Nelson" <Mark.J.Nelson at sun.com> writes: > >> I do not expect full, critical review of the manifest content at this >> time. In fact, if you review my todo list (top o' the webrev), you'll >> see some things that would make that more difficult. >> >> This packages today's nightly bits correctly and completely, with only >> expected errors (as noted in the todo list, or per my recently filed >> bug against the sharemgr makefiles.) >> >> http://cr.opensolaris.org/~mjnelson/webrev.sparcsupport/ >> >> I completely expect to do more complete group/owner/mode default >> settings, and to pull out the zones variant settings into a hollow pkg >> include file (with the transforms to add 'em back). >> >> Anyway, it's sufficient, I think, for the project gate. I hope you'll >> agree. >> >> I apologize now for the webrev ordering and size. I did not rename >> the old manifests, so the remove/add is legitimate. I can do that if >> folks think it worthwhile. > > I'm not sure in the long run, but it'd sure make them easier to follow > now. > > Some comments > > > exception_lists/packaging: > > This file used to be full of handy comments explaining, to at least > some limited degree what things were and why they were excepted. > Why did you remove them? > > 36: Why except spwr? Shouldn't that be in extras? > > pkg/Makefile: > > 65: I kinda liked those one per-line, pity the first person to add > one near the start and possibly have to re-flow the entire set. > > 517: You're using ./pkgmogrify, but not building it from > pkgmogrify.py I'm guessing this is temporary until a pkg5 with > pkgmogrify makes it into the wild? Either way, this will bomb > on people who don't already have $SRC/pkg/pkgmogrify (you > should clobber it, too) > > license_files/*: > > Should your change comments include?: > 11126 need to deal with licenses > > pkg/pkgmogrify.py: > > This should probably be the same version as the one in pkg-gate, no? > > pkgdefs/*: > > Please test the changes here from my diffs. I didn't. > Alternatively; back them out, assuming pkgdefs will go away > completely. > > I deliberately ignored any file containing primarily changes made by me, > and those that seemed purely the consequence of the nightly sync, and > identical to the ON copy. > > I'd like to call out especially the libc changes, which are intended to > default to the "use ksh93 for wordexp" side of Roland's ksh93switch > conditional, and remove the condition itself. > > I looked at some of the manifest changes, but then my brain started > melting. > > -- Rich > _______________________________________________ > on-ips-dev mailing list > on-ips-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/on-ips-dev > -- , _ _ , { \/`o;====- Olga Kryzhanovska -====;o`\/ } .----'-/`-/ olga.kryzhanovska at gmail.com \-`\-'----. `'-..-| / Solaris/BSD//C/C++ programmer \ |-..-'` /\/\ /\/\ `--` `--`
