2010/3/25 ????? ???????????? <olga.kryzhanovska at gmail.com>:
> Please review the following for the ksh93 project update 2 bugfix 1 milestone:
>
> http://cr.opensolaris.org/~fleyta/ksh93_update2_bugfix1_20100324_02_webrev/
>
> The new webrev includes all changes requested and bug fixes since the
> last webrev.
>
> Please respond by Friday 26 March.
>

You change usr/src/lib/libshell/common/tests/sun_solaris* without
updating the year in the CDDL license to 2010. AFAIK ON rules require
that the year must match the year of the putback, not the year of the
last edit.

Other than that... I've reviewed all parts of
http://cr.opensolaris.org/~fleyta/ksh93_update2_bugfix1_20100324_02_webrev/
and the changes look good to me.
-- 
Jennifer Pioch, Uni Frankfurt

Reply via email to