Thank you for reporting this bug and attaching the patch ...

Anyway I can't import my pidgin logs when using your patch. There are two 
problems (for .html log import):
1.  My messages are surrounded by the </b></font> tags on the left and by the 
<br/> tag on the right. Regarding your code, it seems to me that your message 
starts _after_ the <br/> tag. Therefore the string beginMessage isn't found in 
line (historyimport.cpp::513) and so the resulting messageText is only rubbish.
2. I've got some cases where there are special formats inside the message. E.g. 
something like this:
<font color="#A82F2F"><font size="2">(22:12:33)</font> <b>Nick:</b></font> 
<font sml="AIM/ICQ">[MessageText]</font><br/>
In such cases your way of handling the logs doesn't filter out the <font ...> 
tag.

Don't you think it's better to use the QXmlStreamReader and adjust the
code so that it supports your kind of pidgin logs? I was also asking
myself how fast the use of QRegExp is in contrast to the xml-stream
reader. (sorry for my poor english).

Can you tell me the structure of your logs? Or maybe supply me with some
example logs? What a pity that pidgin's logs differ so much ....

Regards,
Timo

-- 
Kopete does not import pidgin history
https://bugs.launchpad.net/bugs/378428
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to kdenetwork in ubuntu.

-- 
kubuntu-bugs mailing list
kubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs

Reply via email to