Comment on attachment 99331
Rotate documents correctly
Review of attachment 99331:
-----------------------------------------------------------------
This looks good to me, except the confusing NONE/LANDSCAPE thing.
Adrian, does the PostScript part looks good to you?
::: libspectre/spectre-device.c
@@ +206,4 @@
> return SPECTRE_STATUS_RENDER_ERROR;
> }
>
> + if (rc->orientation == NONE || rc->orientation == LANDSCAPE) {
Why NONE and LANDSCAPE? shouldn't we invert width/height when
orientation is LANDSCAPE and SEASCAPE? Ah, I know what's going on, you
are using the internal values of the parser (my fault, I think I
suggested it) but rc->orientation is actually a SpectreOrientation enum
value, so you should use SPECTRE_ORIENTATION_PORTRAIT ||
SPECTRE_ORIENTATION_REVERSE_PORTRAIT that are 0 and 2 like NONE and
LANDSCAPE in the internal parser.
@@ +269,4 @@
> args[arg++] = "-dNOPLATFONTS";
>
> if (rc->width != -1 && rc->height != -1) {
> + if (rc->orientation == NONE || rc->orientation == LANDSCAPE) {
Same here.
--
You received this bug notification because you are a member of Kubuntu
Bugs, which is subscribed to libspectre in Ubuntu.
https://bugs.launchpad.net/bugs/1242678
Title:
evince cannot render some EPS files
To manage notifications about this bug go to:
https://bugs.launchpad.net/evince/+bug/1242678/+subscriptions
--
kubuntu-bugs mailing list
kubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kubuntu-bugs
