Thanks for your comments Dmitry, I ll try fixing them but the one about export LD_LIBRARY_PATH didn't work for me and that's why I adopted this work around. Could you please try it locally and let me know if it works for you. So far I tried exporting as well as setting it inline but none of them work.
Cheers On Tue, Apr 15, 2014 at 12:51 PM, Dmitry Shachnev <mity...@gmail.com> wrote: > Review: Needs Fixing > > Thanks for your work! My comments: > > - Please build-depend on xauth. Xvfb only recommends xauth, while it is > needed for running the tests. > - Please use dh_auto_test instead of make check. This way the tests will > be properly skipped when DEB_BUILD_OPTIONS contains nocheck. See other Qt > modules for example of how to do that. > - Instead of "cp -r $(CURDIR)/builddir/lib/*/ $(CURDIR)/lib", you can > simply export LD_LIBRARY_PATH or QT_PLUGIN_PATH. Again, see other Qt > modules. > - There is something weird with the version number in debian/changelog. > -- > > https://code.launchpad.net/~iahmad/kubuntu-packaging/qtcreator/+merge/215802 > You are the owner of lp:~iahmad/kubuntu-packaging/qtcreator. > -- https://code.launchpad.net/~iahmad/kubuntu-packaging/qtcreator/+merge/215802 Your team Kubuntu Packagers is subscribed to branch lp:~kubuntu-packagers/kubuntu-packaging/qtcreator. -- kubuntu-devel mailing list kubuntu-devel@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel
