-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126680/#review90800
-----------------------------------------------------------

Ship it!


Looks good to me!
We will probably annoy the translators and maybe icon designers slightly ^^
Now only libdiscover needs some different name (or private directory), then we 
can update it for Debian :-)

- Matthias Klumpp


On Jan. 8, 2016, 5:14 nachm., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126680/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 5:14 nachm.)
> 
> 
> Review request for Kubuntu, Muon Package Management Suite and Matthias Klumpp.
> 
> 
> Repository: discover
> 
> 
> Description
> -------
> 
> Renames everything as discussed in the mail thread.
> 
> This also renames `muon-updater` to `plasma-discover-updater`. It looks quite 
> terrible, but it's bound to be deprecated as well, so I wouldn't worry too 
> much.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c5f29b9 
>   Messages.sh a1fe946 
>   discover/CMakeLists.txt f4bdf53 
>   discover/icons/128-apps-muondiscover.png a20f474 
>   discover/icons/128-apps-plasmadiscover.png PRE-CREATION 
>   discover/icons/16-apps-muondiscover.png d5f39f2 
>   discover/icons/16-apps-plasmadiscover.png PRE-CREATION 
>   discover/icons/22-apps-muondiscover.png 8858e7f 
>   discover/icons/22-apps-plasmadiscover.png PRE-CREATION 
>   discover/icons/32-apps-muondiscover.png e6ba232 
>   discover/icons/32-apps-plasmadiscover.png PRE-CREATION 
>   discover/icons/48-apps-muondiscover.png 81d05b1 
>   discover/icons/48-apps-plasmadiscover.png PRE-CREATION 
>   discover/icons/CMakeLists.txt ac883a6 
>   discover/icons/sc-apps-muondiscover.svgz b581cac 
>   discover/icons/sc-apps-plasmadiscover.svgz PRE-CREATION 
>   discover/main.cpp ce76436 
>   discover/muondiscoverui.rc 375c6d8 
>   discover/org.kde.discover.desktop 57096b3 
>   discover/plasmadiscoverui.rc PRE-CREATION 
>   exporter/CMakeLists.txt 660e4a0 
>   exporter/main.cpp 5f16beb 
>   libdiscover/CMakeLists.txt f810c4b 
>   libdiscover/backends/ApplicationBackend/Application.cpp bf457bc 
>   libdiscover/backends/PackageKitBackend/CMakeLists.txt f8a0fb6 
>   libdiscover/backends/PackageKitBackend/PackageKitUpdater.h 1ff4862 
>   libdiscover/resources/AbstractResourcesBackend.h 3ed4abb 
>   libdiscover/resources/discoverabstractnotifier.notifyrc PRE-CREATION 
>   libdiscover/resources/muonabstractnotifier.notifyrc b2bfcb9 
>   notifier/CMakeLists.txt d475d0f 
>   notifier/DiscoverNotifier.cpp 4e803a8 
>   updater/CMakeLists.txt 5d82bab 
>   updater/ChangelogWidget.cpp b725554 
>   updater/main.cpp b5a4bda 
>   updater/muon-updater.desktop 9d7b19d 
>   updater/muonupdaterui.rc 5ccbce8 
>   updater/plasma-discover-updater.desktop PRE-CREATION 
>   updater/plasmadiscoverupdaterui.rc PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126680/diff/
> 
> 
> Testing
> -------
> 
> Still works, apparently.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-- 
kubuntu-devel mailing list
kubuntu-devel@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/kubuntu-devel

Reply via email to