Avi Kivity wrote: > Dong, Eddie wrote: >> Move per VCPU mmu_memory_cache to be VM basis. >> >> Your opnion? >> >> Eddie >> >> diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h >> index 0632d0b..77989b4 100644 >> --- a/drivers/kvm/kvm.h >> +++ b/drivers/kvm/kvm.h >> @@ -300,11 +300,6 @@ struct kvm_vcpu { >> >> struct kvm_mmu mmu; >> >> - struct kvm_mmu_memory_cache mmu_pte_chain_cache; >> - struct kvm_mmu_memory_cache mmu_rmap_desc_cache; >> - struct kvm_mmu_memory_cache mmu_page_cache; >> - struct kvm_mmu_memory_cache mmu_page_header_cache; - >> gfn_t last_pt_write_gfn; >> int last_pt_write_count; >> >> @@ -383,6 +378,11 @@ struct kvm { >> unsigned long rmap_overflow; >> struct list_head vm_list; >> struct file *filp; >> + >> + struct kvm_mmu_memory_cache mmu_pte_chain_cache; >> + struct kvm_mmu_memory_cache mmu_rmap_desc_cache; >> + struct kvm_mmu_memory_cache mmu_page_cache; >> + struct kvm_mmu_memory_cache mmu_page_header_cache; }; >> >> > > This exposes a race:
Yes, We will provide other pathes for real SMP support. This one is just for pre-movement. BTW, at bigening, our SMP work may start with big lock (only one VCPU get accessing to shadow PT), and then gradually move to fine lock, and we expect to start SMP debug next week. Or you want to see a big one together after it gets up? Eddie ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel