On Thursday 31 May 2007 12:11:16 Ingo Molnar wrote: > > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > > > > + if (wrmsr_safe(MSR_KVM_API_MAGIC, __pa(para_state), 0)) { > > > > + printk(KERN_INFO "KVM guest: WRMSR probe failed.\n"); > > > > + return -ENOENT; > > > > + } > > > > > > How about printk(KERN_INFO "I am not a KVM guest\n");? > > > > Actually paravirt probes that fail should be silent; similar like > > drivers that don't find their hardware should do the same. Otherwise > > if there are later distro kernels with various of those compiled in > > the boot log would become quite noisy > > yeah. I suspect printing that it's executing in native mode is OK.
But only a single printk for that please -Andi ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel