Anthony Liguori wrote: >> >> Hypercalls should return kvm-specific error codes (defined in >> include/linux/kvm_para.h), not Linux error codes, as they could be >> used in operating systems which have different values for E2BIG and >> friends. > > If Linux's errnos are stable, we could just use them and let a > non-Linux guest define a set of KVM_E2BIG, etc.? It just seemed > pretty ugly to add a bunch of these.
The ugliness will serve to remind us that this is a potentially non-Linux path. In this particular case, the names are not present in guest-visible headers, but any other that is made visible must have a non-Linux-dependent name, so I don't see why error numbers should be treated specially. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
