On Mon, 2007-07-23 at 19:32 +0800, Avi Kivity wrote: > Shaohua Li wrote: > > Make KVM guest pages be allocated dynamically and able to be swaped > out. > > > > One issue: all inodes returned from anon_inode_getfd are shared, > > if one module changes field of the inode, other moduels might break. > > Should we introduce a new API to not share inode? > > > > Signed-off-by: Shaohua Li <[EMAIL PROTECTED]> > > --- > > drivers/kvm/kvm.h | 8 + > > drivers/kvm/kvm_main.c | 220 > +++++++++++++++++++++++++++++++++++++++++++++---- > > 2 files changed, 211 insertions(+), 17 deletions(-) > > > > + > > + /* > > + * We just zap vcpu 0's page table. For a SMP guest, we should > zap all > > + * vcpus'. It's better shadow page table is per-vm. > > + */ > > + if (PagePrivate(page)) > > + kvm_mmu_zap_pagetbl(&kvm->vcpus[0], page->index); > > + > > > > You're not removing any shadows of the page, in case that page is a > guest page table. But I don't see anything wrong with it -- the page > won't change while it's in swap. You are right. Should we?
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
