Shaohua Li wrote: >> >>> 1. vmcs_readl/vmcs_writel are called with preempt enabled >>> >>> >> Why is that bad? >> > 1. raw_smp_processor_id() > 2. migrate to other cpu > 3. current->kvm_vcpu->cpu != the cpu id of step 1. > you will see the warning. >
Ah, that code is gone from preempt-hooks, hence I didn't understand you. The current version of the patchset does not change vmcs_readl/vmcs_writel. So I think everything is safe. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
