Nguyen Anh Quynh wrote:
> On 7/24/07, Avi Kivity <[EMAIL PROTECTED]> wrote:
>> Nguyen Anh Quynh wrote:
>> > This patch removes some unused functions in mmu.c
>>
>> > -static int is_nx(struct kvm_vcpu *vcpu)
>> > -{
>> > -     return vcpu->shadow_efer & EFER_NX;
>> > -}
>> > -
>>
>> is_nx() for example, is used.
>>
>> More care, please.
>
> Oops, I looked again. The way we handle static functions with
> paging_tmpl.h is weird.
>
> How about moving these functions there?

It's wierder than you think.  You'll get multiple definition errors.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to 
panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Reply via email to