>> This patch replaces vmcs_write32_fixedbits() with
>adjust_vmx_controls(),
>
>It still doesn't say why, but I can now see it: this is code
>from Xen. I have no objection to copying Xen code, but it needs to be
documented in
>the changelog, and there needs to be a good reason as to why you're
>replacing existing code rather than improving it. So far I don't see
>this reason
We want to enable MSR BITMAP and VTPR for VMX guest, which depend on
this, I think you're already aware this.
And another reason is, all physical CPUs on the system should support
the _same_ VMX features set, or obviously it's weird that one CPU
support Intel VTPR feature while some other not. This is a rare case,
but basically we should detect it when KVM is being initialized, and
this patch also helps.
>
>>
>> -static struct vmcs_descriptor {
>> +static struct vmcs_config {
>
>Why the name change? Just for Xen compatibility? If that's the only
>reason, it's insufficent.
>
If you agree the above, this becomes reasonable.
-Xin
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
