>-----Original Message-----
>From: [EMAIL PROTECTED]
>[mailto:[EMAIL PROTECTED] On Behalf Of Avi Kivity
>Sent: 2007年8月2日 19:00
>To: Yang, Sheng
>Cc: kvm-devel@lists.sourceforge.net
>Subject: Re: [kvm-devel] [PATCH 2/2] Add MSR Bitmap support in VMX
>
>Yang, Sheng wrote:
>> Add MSR Bitmap support in VMX so that some execution of RDMSR or WRMSR
>> won't cause a VM exit.
>>
>> Signed-off-by: Sheng Yang <[EMAIL PROTECTED]>
>> Signed-off-by: Qing He <[EMAIL PROTECTED]>
>> ---
>> drivers/kvm/vmx.c | 44
>+++++++++++++++++++++++++++++++++++++++++++-
>> drivers/kvm/vmx.h | 3 +++
>> 2 files changed, 46 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c
>> index 3b901fe..bebe0d4 100644
>> --- a/drivers/kvm/vmx.c
>> +++ b/drivers/kvm/vmx.c
>> @@ -71,6 +71,7 @@ static DEFINE_PER_CPU(struct vmcs *, current_vmcs);
>>
>> static struct page *vmx_io_bitmap_a;
>> static struct page *vmx_io_bitmap_b;
>> +static struct page *vmx_msr_bitmap;
>>
>>
>
>hmm. While there's nothing wrong with the patch, there is a simpler way
>to do this:
>
> static unsigned long vmx_msr_bitmap[PAGE_SIZE / sizeof(unsigned
>long)] __aligned(PAGE_SIZE);
>
>now there's no need to allocate, error-check, free, or kmap the memory.
>The io bitmaps can receive similar treatment.
Well, though not so important, kmapping do have a tiny advantage, it uses less
virtual space if HIGHMEM is used. This makes sense when 1G limited kernel space
is used, although it's highly unlikely to be a real problem.
Either way, I'm OK.
>
>--
>error compiling committee.c: too many arguments to function
>
>
>-------------------------------------------------------------------------
>This SF.net email is sponsored by: Splunk Inc.
>Still grepping through log files to find problems? Stop.
>Now Search log events and configuration files using AJAX and a browser.
>Download your FREE copy of Splunk now >> http://get.splunk.com/
>_______________________________________________
>kvm-devel mailing list
>kvm-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/kvm-devel
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
