Hi Laurent, Fair enough. I think the patch can go in.
Thanks & Regards, Nitin Linux Open Source Technology Center, Intel Corporation ------------------------------------------------------------------------ -------- The Mind is like a parachute; it works much better when it's open. -----Original Message----- From: Laurent Vivier [mailto:[EMAIL PROTECTED] Sent: Wednesday, October 03, 2007 12:24 AM To: Kamble, Nitin A Cc: [email protected]; [EMAIL PROTECTED] Subject: Re: [PATCH] Correct management of REP prefix Kamble, Nitin A wrote: > Hi Laurent, > This patch looks much cleaner to me. > > I see you are saving the regs like this in the patch. > memcpy(c->regs, ctxt->vcpu->regs, sizeof c->regs); > > But I don't see any place in the patch these regs getting restored after > failure. > > Is it taken care of the code outside of the patch? In fact, during the emulation the function works on c->regs and copy them into ctxt->vpcu->regs on success (see label "writeback"). The result is in vcpu not in c->regs. If the function fails, as we didn't modify ctxt->vcpu->regs, we can re-start with original values by copying again ctxt->vcpu->regs to c->regs. Regargs, Laurent -- ------------- [EMAIL PROTECTED] -------------- "Software is hard" - Donald Knuth ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ kvm-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kvm-devel
