On Mon, 8 Oct 2007, Anthony Liguori wrote: > Carlo Marcelo Arenas Belon wrote: >> Using gcc4 to compile qemu will generate broken code for its cpu emulation >> but should be fine if using kvm only. >> >> This will allow users that have no access to gcc4 on their platforms to at >> least get kvm compiled and use it while preventing them to run a broken >> qemu if kvm is not available. >> > > This is a pretty bad thing IMHO. There are other patches out there that > allow QEMU (even with -no-kvm) to work with GCC4. A random check like > this is going to result in difficulties down the road. Maybe a release > of GCC4 will allow QEMU to work in the future. A check like this is > just way too general IMHO. > > If you're going to do anything, a firm warning when compiling with a > GCC4 override would be the best thing.
I disagree with the compile warning. There have been times in the past when I've forgotten to "insmod kvm*.ko" long after the compile stage, and wound up wondering why the virtual machine was slower. Even when I first started using KVM, I had no positive feedback that KVM was even working properly (was the device node created? am I using a cpu with the correct extensions? etc). I eventually figured out that if 'lsmod' showed kvm-intel.ko usage > 0, then I knew it was working. I would think that anyone who is using KVM has the required hardware and wants to be sure that KVM is really being used. Specifying -no-kvm is an excellent tool for debugging purposes, but I don't want KVM to fail silently on me and pretend that I typed -no-kvm, especially if I'm using GCC 4.x and never intended to use the QEMU portion anyway. I would much rather see KVM fail gracefully, rather than revert to QEMU, regardless of the compiler version being used. -Byron -- Byron Stanoszek Ph: (330) 644-3059 Systems Programmer Fax: (330) 644-8110 Commercial Timesharing Inc. Email: [EMAIL PROTECTED] ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
