[EMAIL PROTECTED] wrote: > On Mon, 2007-10-15 at 11:29 +0200, Avi Kivity wrote: >> Patch looks good, but I'm missing a signed-off-by: line. >> >> Eddie, can you also take a look? > > I split the patch in two. The first one fixes the host OS kernel > divide by zero problem. The second cleans up apic_get_tmcct() a bit. > Both now include a signed-off-by. > > Kevin
Good! A minor comments: + while (counter_passed > tmcct) + counter_passed -= tmcct; may be: counter_passed %= tmcct, or use __div64_32. + tmcct -= counter_passed; BTW, would u like to give clean div64_64 to div64_32 too? I think 64/32 is enough and faster. thx, eddie ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
