On Tue, 2007-10-23 at 10:24 -0500, Hollis Blanchard wrote: > On Tue, 2007-10-23 at 10:21 -0500, Hollis Blanchard wrote: > > > > > -CFLAGS += -I $(KERNELDIR)/include $(autodepend-flags) -g > > > -fomit-frame-pointer \ > > > - -Wall > > > +CFLAGS += $(autodepend-flags) -g -fomit-frame-pointer -Wall > > > CFLAGS += $(call cc-option, -fno-stack-protector, "") > > > CFLAGS += $(call cc-option, -fno-stack-protector-all, "") > > > > You seem to be adding "-I $(KERNELDIR)/include" twice: once here, and > > once in each config-*.mak file. > > My bad; I read the diff backwards. :) > > Are you sure about that move though? Why doesn't every arch need that -I > switch?
Actually no. For our powerpc stuff having -I $(KERNELDIR)/include causes hell with errno.h & it's definitions. Since we do not include any of the kernel headers in our codes we don't need this, but x86 does as it includes nice headears like "linux/paravirt.h". Now including kernel headers is a totally different argument. But basically from what I know is you should "never" do it. > ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
