Ryan Harper wrote: > * Anthony Liguori <[EMAIL PROTECTED]> [2007-12-07 15:07]: > >> Ryan Harper wrote: >> >>> * Anthony Liguori <[EMAIL PROTECTED]> [2007-12-07 14:49]: >>> >>> >>>>> + >>>>> +CPUState *first_cpu; >>>>> >>>>> >>>>> >>>> This should probably be static. >>>> >>>> >>> doh, should be extern actually since it's defined elsewhere. >>> >>> >> Perhaps you want cpu_single_env instead of first_cpu? >> > > I wasn't quite sure given the comments surrounding its declaration: > > from exec.c: > > CPUState *first_cpu; > /* current CPU in the current thread. It is only valid inside > cpu_exec() */ > CPUState *cpu_single_env; >
Yeah, I guess since you build this at init time, first_cpu is more appropriate. Regards, Anthony Liguori ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
