Hollis Blanchard wrote: > On Fri, 2007-12-14 at 10:07 +0100, Christian Ehrhardt wrote: >> Hollis Blanchard wrote: >>> A comment to explain why the icache needs flushing only in the KVM >> case >>> would be useful. Other than that I'm fine with it. >>> >>> Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]> >> AFAIK Plain qemu does not directly execute guest code on the >> processor, >> so the icache is not an issue for it. >> Qemu itself has the flush_icache_range function only as helper for the >> dynamic code generation. >> But we may now write executable guest code with our intercepted mmio >> handling that is directly executed when switching back to the guest >> context, therefore we need that invalidation in the kvm case. >> >> For the case that I'm overlooking something in plain qemu, so that it >> might need it too I add [EMAIL PROTECTED] for comments from there, >> but currently I think to have it in #ifdef USE_KVM is the right way. >> >> >> P.S. Hollis did you mean you would like to see a comment in the code >> where that call takes place? > > Yes! Hopefully much shorter than this email... :-P > comment added, rebased and resent together with a updated mmio callback simplification patch - I hope I didn't overlook a response to the mmio callback thread again this time ;-)
-- Grüsse / regards, Christian Ehrhardt IBM Linux Technology Center, Open Virtualization +49 7031/16-3385 [EMAIL PROTECTED] [EMAIL PROTECTED] IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Johann Weihen Geschäftsführung: Herbert Kircher Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
