On Tue, Dec 18, 2007 at 06:20:03PM +0200, Avi Kivity wrote: > Carlo Marcelo Arenas Belon wrote: > > The following patch eliminates the uninitialized mem pointer, using > > instead the corresponding entry from the slots array to fix : > > > > libkvm.c:580: warning: 'mem' is used uninitialized in this function
if this part of the patch is applied.. > > Also changes the formatting type for phys_addr to long to prevent : > > > > libkvm.c:581: warning: format '%llx' expects type 'long long unsigned int' > > , but argument 5 has type 'long unsigned int' this warning will be triggered in the next compile. > Applied, thanks. But please avoid unrelated changes in the same patch > in the future. sorry about that, will do, even if I disagree there were unrelated as explained above. so just to be clear on this?, would you rather have these changes in a patch series, or as unrelated patches with the second one fixing a formatting issue that the first one triggered? if the later, how to handle in that case the dependency so that they don't get applied in incorrect order triggering conflicts? I understand that the first part of it has higher importance than the second one, but I would rather have them applied together as they make IMHO more sense as an atomic change. Carlo ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ kvm-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/kvm-devel
