Hollis Blanchard wrote: > On Wed, 2008-01-09 at 10:39 +0200, Avi Kivity wrote: > >> Zhao, Yunfeng wrote: >> >>> Today's tip fails to compile with following error messages: >>> >>> >> [...] >> >> Fixed now. Hollis, I had to revert your asm symlink patch to fix this, >> so we need to find an alternative solution to that problem. >> > > qemu ends up including <asm/byteorder.h> from /usr. > > libkvm, on the other hand, ends up including <asm/kvm.h> from the target > kernel tree. > > Since the two components are meaning completely different things when > referring to the "asm" directory, we should use different include paths. > The best long-term solution would probably be to remove "-I > $(KERNELDIR)/include" from libkvm, and instead build against a copy of > the KVM headers (maybe copied over with that "make sync" target?). > > Avi, I think you're responsible for all the build directory munging we > do currently; what do you think about that? >
I agree. The traditional way is to build against installed headers; but we don't want to do that at this stage. So your suggestion is the closest thing. But we should make the sync target implicit so users don't have that additional step. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
