This patch seems reasonable to me. But FWIW, with extboot, it's possible to implement the -kernel option in a saner way. extboot already has code to take over int19 and load a kernel from memory on boot. It was based on the old -kernel support in QEMU (prior to hpa's rewrite) so it's not enabled at the moment. It should be pretty easy to update it though.
This approach would allow -kernel to be used without any disk (which also solves your problem, but in a different way). We can also eliminate all the boot sector hijacking silliness. Regards, Anthony Liguori Glauber de Oliveira Costa wrote: > Reposting to kvm-devel, since aliguori notices that I'm relying on > non-upstream features of qemu > > ---------- Forwarded message ---------- > From: Glauber de Oliveira Costa <[EMAIL PROTECTED]> > Date: Feb 8, 2008 5:05 AM > Subject: [PATCH] boot a linux kernel from non-ide device > To: [EMAIL PROTECTED] > > > Since it's now possible to use the -drive option, the test for something > in the index 0 of the IDE bus is too restrictive. > > A better idea, IMHO, is to check if the user specified any bootable device, > and only if not, fallback to the default, compatible behaviour of checking > hda regardless of the presence of a boot=on arg. > > -- > Glauber de Oliveira Costa. > "Free as in Freedom" > http://glommer.net > > "The less confident you are, the more serious you have to act." > > > > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
